fix: proper to_ptr type cast to c_char #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 31, 2024
On some platforms casting to `i8` is invalid as the compiler expects a `u8`. This applies to `CString` and `String` `.to_ptr()` calls. Signed-off-by: Max Newcomer <[email protected]>
maxwnewcomer
force-pushed
the
fix/c_char-casting
branch
from
7486210 to
79c0bbe
Compare
tiagolobocastro
approved these changes
Dec 31, 2024
dsharma-dc
approved these changes
Jan 6, 2025
abhilashshetty04
approved these changes
Jan 6, 2025
|
thanks @maxwnewcomer |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform agnostic
c_chartype castingInstead of hard-casting to
i8oru8we can just cast to the built instd::os::raw::c_char. This change allows for fullarm64compilation of mayastor.Related
.as_ptr()type casts on some arm platforms #1795spdk-rschanges)