Patch a bug in dpdk which caused build failures in rare cases #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for spdk/spdk#825 and https://bugs.dpdk.org/show_bug.cgi?id=356 and some other nits.
gila
approved these changes
Oct 23, 2019
mtzaurus
pushed a commit
that referenced
this pull request
Sep 6, 2021
22: feat(store): define persistent data structs r=paulyoong a=paulyoong Initial definition of structures that need to be saved in the persistent store. Resolves: CAS-819 Co-authored-by: Paul Yoong <[email protected]>
paulyoong
pushed a commit
that referenced
this pull request
May 27, 2022
22: feat(bench): add benchmarks crate for io-engine operations r=tiagolobocastro a=tiagolobocastro feat(bench): add benchmarks crate for io-engine operations Adds nexus creation benchmark via gRPC and directly. The benchmarks are added on a different crate (io-engine-bench) because otherwise on every change on the bench code every io-engine crate binaries has to be built which takes time. The downside is that io-engine binaries release or debug need to be built prior to running the benches. (This can easily be changed if we want to) The benchmark needs to run from the io-engine-bench folder because: 1- we have a runner to run it as root (required by the in-binary benchmark) 2- we have code in the runner to chown the results to $USER and copy them back and forth from the io-engine-bench/results/criterion location and the target location. To run the benchmark in release: RUST_LOG=disable cargo bench -p io-engine-bench To run the debug: RUST_LOG=disable $RUST_NIGHTLY_PATH/bin/cargo bench -p io-engine-bench --profile=dev The criterion results are placed in the cargo target folder. You may direct your browser to this location to inspect the results. Co-authored-by: Tiago Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for spdk/spdk#825 and
https://bugs.dpdk.org/show_bug.cgi?id=356 and some other nits.