fix(moac): timeouts when updating volume custom resource #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that the objects (old and new one) were basically the same except that order of entries in replicas array was different. Problem #1 is that we do useless update of CR and #2 is that k8s does not emit mod event in such case so volume-operator was timing out waiting for the event. The fix is to enforce deterministic order of entries in replicas array so that deep-equal compares the objects correctly.
paulyoong
approved these changes
May 26, 2021
tiagolobocastro
approved these changes
May 26, 2021
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the objects (old and new one) were basically
the same except that order of entries in replicas array was different.
Problem #1 is that we do useless update of CR and #2 is that k8s
does not emit mod event in such case so volume-operator was timing
out waiting for the event.
The fix is to enforce deterministic order of entries in replicas
array so that deep-equal compares the objects correctly.