Skip to content

Commit

Permalink
Fix frontned issues (#565)
Browse files Browse the repository at this point in the history
This PR takes care of all the styling issues happening due to the bad configuration of postcss.
  • Loading branch information
usmanchaudhryme authored Sep 20, 2022
1 parent 4ff87cd commit f523050
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 19 deletions.
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@ public/static/*.map
public/static/emojis.json
webpack-stats/*.json
.env.production
public/static/*.css
public/static/*.html
public/static/*.js
public/static/*.LICENSE.txt
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
"postcss-custom-media": "8.0.0",
"postcss-custom-properties": "12.1.7",
"postcss-import": "14.1.0",
"postcss-loader": "7.0.0",
"postcss-loader": "7.0.1",
"postcss-pxtorem": "6.0.0",
"postcss-reporter": "7.0.5",
"postcss-url": "10.1.3",
Expand Down
12 changes: 1 addition & 11 deletions src/styles/jso.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// JavaScript Style Objects (jso)
import { after, css, media } from './jss'
import { css, media, after } from './jss'

// TODO: Note web vs native properties
// TODO: Should web only props live in cso?
Expand Down Expand Up @@ -305,9 +305,6 @@ export const monoRegular = {
fontStyle: 'normal',
fontWeight: 400,
}
export const italic = {
fontStyle: 'italic',
}

// TODO: Turn into base level text components (web)
export const sansRegularCSS = css(sansRegular)
Expand Down Expand Up @@ -413,7 +410,6 @@ export const hitarea = {
content: '""',
backgroundColor: 'rgba(0, 0, 0, 0)',
}
export const pointerEvents = { pointerEvents: 'all' }

// usually apply to :after of a container element
export const clearFix = css(
Expand All @@ -435,9 +431,3 @@ export const resetInput = css(
outline: 'none',
},
)

export const buttonHighlightStyle = {}
export const alignLeft = {}
export const alignCenter = {}
export const transitionHeight = {}

7 changes: 4 additions & 3 deletions webpack.prod.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ module.exports = env => ({
loader: 'postcss-loader',
options: {
postcssOptions:{
plugins: loader => [
postcssImport({ result: { messages: { dependency: loader } } }),
plugins: [
postcssImport(),
postcssUrl(),
postcssCustomProperties(),
postcssApply(),
Expand All @@ -110,7 +110,8 @@ module.exports = env => ({
postcssReporter(),
]
}
}}]
}
}]
},
{
test: /\.html$/,
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6952,10 +6952,10 @@ [email protected]:
read-cache "^1.0.0"
resolve "^1.1.7"

[email protected].0:
version "7.0.0"
resolved "https://registry.yarnpkg.com/postcss-loader/-/postcss-loader-7.0.0.tgz#367d10eb1c5f1d93700e6b399683a6dc7c3af396"
integrity sha512-IDyttebFzTSY6DI24KuHUcBjbAev1i+RyICoPEWcAstZsj03r533uMXtDn506l6/wlsRYiS5XBdx7TpccCsyUg==
[email protected].1:
version "7.0.1"
resolved "https://registry.yarnpkg.com/postcss-loader/-/postcss-loader-7.0.1.tgz#4c883cc0a1b2bfe2074377b7a74c1cd805684395"
integrity sha512-VRviFEyYlLjctSM93gAZtcJJ/iSkPZ79zWbN/1fSH+NisBByEiVLqpdVDrPLVSi8DX0oJo12kL/GppTBdKVXiQ==
dependencies:
cosmiconfig "^7.0.0"
klona "^2.0.5"
Expand Down

0 comments on commit f523050

Please sign in to comment.