Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[daikin] Add semantic tags to channels #18315

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[daikin] Add semantic tags to channels #18315

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81fe281
[daikin] Add semantic tags to channels
jimtng Feb 22, 2025
3010537
change to level for fan speed
jimtng Feb 23, 2025
cba5016
add mode property
jimtng Feb 23, 2025
7e4b671
Reorder tags and change zone point/property
jimtng Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[daikin] Add semantic tags to channels 
Signed-off-by: Jimmy Tanagra <[email protected]>
  • Loading branch information
@jimtng
jimtng committed Feb 22, 2025
commit 81fe281845b761aa5cb457637af919ffba0d4ba2
55 changes: 55 additions & 0 deletions bundles/org.openhab.binding.daikin/src/main/resources/OH-INF/thing/thing-types.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@
<description>Power for the AC unit</description>
<category>Switch</category>
<autoUpdatePolicy>veto</autoUpdatePolicy>
<tags>
<tag>Switch</tag>
<tag>Power</tag>
</tags>
</channel-type>

<channel-type id="acunit-settemp">
Expand All @@ -104,6 +108,10 @@
<category>Temperature</category>
<state pattern="%.1f %unit%" step="0.5"/>
<autoUpdatePolicy>veto</autoUpdatePolicy>
<tags>
<tag>Setpoint</tag>
<tag>Temperature</tag>
</tags>
</channel-type>

<channel-type id="acunit-indoortemp">
Expand All @@ -112,6 +120,10 @@
<description>The indoor temperature</description>
<category>Temperature</category>
<state readOnly="true" pattern="%.1f %unit%" step="0.5"/>
<tags>
<tag>Measurement</tag>
<tag>Temperature</tag>
</tags>
</channel-type>

<channel-type id="acunit-outdoortemp">
Expand Down Expand Up @@ -144,6 +156,9 @@
</options>
</state>
<autoUpdatePolicy>veto</autoUpdatePolicy>
<tags>
<tag>Control</tag>
</tags>
</channel-type>

<channel-type id="acunit-homekitmode">
Expand Down Expand Up @@ -177,6 +192,10 @@
</options>
</state>
<autoUpdatePolicy>veto</autoUpdatePolicy>
<tags>
<tag>Control</tag>
<tag>Wind</tag>
</tags>
</channel-type>

<channel-type id="acunit-fandir">
Expand Down Expand Up @@ -472,62 +491,98 @@
<label>Fan</label>
<description>Current fan speed setting of the AC unit</description>
<autoUpdatePolicy>veto</autoUpdatePolicy>
<tags>
<tag>Control</tag>
<tag>Wind</tag>
</tags>
</channel-type>

<channel-type id="airbase-acunit-zone1">
<item-type>Switch</item-type>
<label>Zone 1</label>
<description>Zone 1 for the AC unit</description>
<autoUpdatePolicy>veto</autoUpdatePolicy>
<tags>
<tag>Switch</tag>
<tag>Wind</tag>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have this Wind tag documented somewhere? I can imagine a weather device measuring wind, but controlling wind? Isn't it more like "air" being controlled rather than "wind"? I'm not saying anything is wrong, just curious. The Danish word for wind ("vind") is strictly about the wind outside, so controlling it would be god-like. 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL! Inside the house, you can play god and control the wind with openHAB! ;)

These channels controls the air outlet that goes into each room. You can turn it on or shut it off. Some fancier system can let you control the amount of opening too.

I must admit it isn't ideal, but given what's available in the existing list of properties... that's the closest I can think of. The other alternative is Opening maybe?

If I were to invent a new Property, it might be one of these:

  • AirOutlet
  • Air
  • Airflow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW Wind is from here https://github.com/openhab/openhab-core/blob/fd53c4cb1d772c8086e7f4651f19db20bfcadfe6/bundles/org.openhab.core.semantics/model/SemanticTags.csv#L47

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I were to invent a new Property, it might be one of these:\n\nAirOutlet\nAir\nAirflow

AirOutlet may not be sufficient. I have a Danfoss Air recuperator ventilation unit where multiple outlets are connected to the same fan, so can't be individually controlled. I see you proposed Airflow, that might be just the right balance between generic and concrete.

Foot note: for Danfoss Air I can control mode and level, so actually I don't see air control being referenced.

</tags>
</channel-type>

<channel-type id="airbase-acunit-zone2">
<item-type>Switch</item-type>
<label>Zone 2</label>
<description>Zone 2 for the AC unit</description>
<autoUpdatePolicy>veto</autoUpdatePolicy>
<tags>
<tag>Switch</tag>
<tag>Wind</tag>
</tags>
</channel-type>

<channel-type id="airbase-acunit-zone3">
<item-type>Switch</item-type>
<label>Zone 3</label>
<description>Zone 3 for the AC unit</description>
<autoUpdatePolicy>veto</autoUpdatePolicy>
<tags>
<tag>Switch</tag>
<tag>Wind</tag>
</tags>
</channel-type>

<channel-type id="airbase-acunit-zone4">
<item-type>Switch</item-type>
<label>Zone 4</label>
<description>Zone 4 for the AC unit</description>
<autoUpdatePolicy>veto</autoUpdatePolicy>
<tags>
<tag>Switch</tag>
<tag>Wind</tag>
</tags>
</channel-type>

<channel-type id="airbase-acunit-zone5">
<item-type>Switch</item-type>
<label>Zone 5</label>
<description>Zone 5 for the AC unit</description>
<autoUpdatePolicy>veto</autoUpdatePolicy>
<tags>
<tag>Switch</tag>
<tag>Wind</tag>
</tags>
</channel-type>

<channel-type id="airbase-acunit-zone6">
<item-type>Switch</item-type>
<label>Zone 6</label>
<description>Zone 6 for the AC unit</description>
<autoUpdatePolicy>veto</autoUpdatePolicy>
<tags>
<tag>Switch</tag>
<tag>Wind</tag>
</tags>
</channel-type>

<channel-type id="airbase-acunit-zone7">
<item-type>Switch</item-type>
<label>Zone 7</label>
<description>Zone 7 for the AC unit</description>
<autoUpdatePolicy>veto</autoUpdatePolicy>
<tags>
<tag>Switch</tag>
<tag>Wind</tag>
</tags>
</channel-type>

<channel-type id="airbase-acunit-zone8">
<item-type>Switch</item-type>
<label>Zone 8</label>
<description>Zone 8 for the AC unit</description>
<autoUpdatePolicy>veto</autoUpdatePolicy>
<tags>
<tag>Switch</tag>
<tag>Wind</tag>
</tags>
</channel-type>

</thing:thing-descriptions>