-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8339935: Open source several AWT focus tests - series 5 #21103
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 141 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
/* | ||
* @test | ||
* @bug 4472032 | ||
* @summary Switching between lightweight menus by holizontal arrow key works incorrect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
holizontal -> horizontal
public class ProxiedWindowHideTest { | ||
|
||
private static final String INSTRUCTIONS = """ | ||
You will see JFrame with title 'TEST'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks to me like the title is actually "ProxiedWindowHideTest frame".
A tester might decide to fail the test because of this.
/* | ||
* @test | ||
* @bug 4396407 | ||
* @summary Tests that after proxied window were hidden focus is being restored correctly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... after a proxied window is hidden ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok..fixed...
/integrate |
Going to push as commit b1f8d2e.
Your commit was automatically rebased without conflicts. |
Opensource few AWT focus tests
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21103/head:pull/21103
$ git checkout pull/21103
Update a local copy of the PR:
$ git checkout pull/21103
$ git pull https://git.openjdk.org/jdk.git pull/21103/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21103
View PR using the GUI difftool:
$ git pr show -t 21103
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21103.diff
Webrev
Link to Webrev Comment