Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8339935: Open source several AWT focus tests - series 5 #21103

Closed
wants to merge 2 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Sep 20, 2024

Opensource few AWT focus tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8339935: Open source several AWT focus tests - series 5 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21103/head:pull/21103
$ git checkout pull/21103

Update a local copy of the PR:
$ git checkout pull/21103
$ git pull https://git.openjdk.org/jdk.git pull/21103/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21103

View PR using the GUI difftool:
$ git pr show -t 21103

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21103.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2024

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339935: Open source several AWT focus tests - series 5

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 141 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 20, 2024
@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Sep 20, 2024

Webrevs

/*
* @test
* @bug 4472032
* @summary Switching between lightweight menus by holizontal arrow key works incorrect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holizontal -> horizontal

public class ProxiedWindowHideTest {

private static final String INSTRUCTIONS = """
You will see JFrame with title 'TEST'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks to me like the title is actually "ProxiedWindowHideTest frame".
A tester might decide to fail the test because of this.

/*
* @test
* @bug 4396407
* @summary Tests that after proxied window were hidden focus is being restored correctly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... after a proxied window is hidden ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok..fixed...

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 24, 2024
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 25, 2024

Going to push as commit b1f8d2e.
Since your change was applied there have been 150 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 25, 2024
@openjdk openjdk bot closed this Sep 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 25, 2024
@openjdk
Copy link

openjdk bot commented Sep 25, 2024

@prsadhuk Pushed as commit b1f8d2e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8339935 branch September 25, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants