Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8349533: Refactor validator tests shell files to java #23727

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

myankelev
Copy link
Contributor

@myankelev myankelev commented Feb 21, 2025

Changed shell files to be java tests:

  • ./validator/certreplace.sh
  • ./validator/samedn.sh

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349533: Refactor validator tests shell files to java (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23727/head:pull/23727
$ git checkout pull/23727

Update a local copy of the PR:
$ git checkout pull/23727
$ git pull https://git.openjdk.org/jdk.git pull/23727/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23727

View PR using the GUI difftool:
$ git pr show -t 23727

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23727.diff

Using Webrev

Link to Webrev Comment

Changed shell files to be java tests:
* ./validator/certreplace.sh
* ./validator/samedn.sh
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2025

👋 Welcome back myankelev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@myankelev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349533: Refactor validator tests shell files to java

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 140 new commits pushed to the master branch:

  • 39cb493: 8348106: Catch C++ exception in Java_sun_awt_windows_WTaskbarPeer_setOverlayIcon
  • ddb2569: 8280682: Refactor AOT code source validation checks
  • 65f79c1: 8347335: ZGC: Use limitless mark stack memory
  • e410af0: 8342393: Promote commutative vector IR node sharing
  • f755fad: 8349653: Clarify the docs for MemorySegment::reinterpret
  • a5c9a4d: 8349032: C2: Parse Predicate refactoring in Loop Unswitching broke fix for JDK-8290850
  • 302bed0: 8350499: Minimal build fails with slowdebug builds
  • 0795d11: 8350464: The flags to set the native priority for the VMThread and Java threads need a broader range
  • 05b4812: 8350041: Skip test/jdk/java/lang/String/nativeEncoding/StringPlatformChars.java on static JDK
  • a891630: 8350480: RISC-V: Relax assertion about registers in C2_MacroAssembler::minmax_fp
  • ... and 130 more: https://git.openjdk.org/jdk/compare/964dd18fd2ba998e5c1efed48e15e516b0c22b19...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@myankelev The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@myankelev myankelev marked this pull request as ready for review February 21, 2025 13:20
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 21, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2025

Webrevs

@myankelev
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored labels Feb 24, 2025
@openjdk
Copy link

openjdk bot commented Feb 24, 2025

@myankelev
Your change (at version 2985d18) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review security [email protected] sponsor Pull request is ready to be sponsored
Development

Successfully merging this pull request may close these issues.

2 participants