Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8350514: Refactor MandatoryWarningHandler to support dynamic verbosity #23730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

archiecobbs
Copy link
Contributor

@archiecobbs archiecobbs commented Feb 21, 2025

This PR is a sub-task split off from JDK-8224228, which seeks to add @SuppressWarnings support for lexical features.

The MandatoryWarningHandler is used by the preview, deprecation, removal, and unchecked mandatory warnings. The constructor takes a boolean verbose flag which is documented to "Specify whether or not detailed messages about individual instances should be given, or whether an aggregate message should be generated at the end of the compilation."

The problem is that this flag doesn't really make sense for warnings that are suppressible via @SuppressWarnings: for such warnings, what we actually want to do is trigger the aggregate message at the end of compilation if and only if there were any warnings that were not suppressed by @SuppressWarnings but were suppressed because the corresponding lint category was not enabled, either because it wasn't enabled by default, or due to an explicit -Xlint:-foo flag.

Currently, we get that same net result, because preview is not suppressible via @SuppressWarnings, and for the other three categories there is logic around the calls to MandatoryWarningHandler.report() to ensure the right thing happens.

It would be simpler and more straightforward for the users of MandatoryWarningHandler to just pass along the currently applicable Lint instance and let MandatoryWarningHandler keep track of whether to generate the aggregate message at the end of the compilation.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350514: Refactor MandatoryWarningHandler to support dynamic verbosity (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23730/head:pull/23730
$ git checkout pull/23730

Update a local copy of the PR:
$ git checkout pull/23730
$ git pull https://git.openjdk.org/jdk.git pull/23730/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23730

View PR using the GUI difftool:
$ git pr show -t 23730

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23730.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2025

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@archiecobbs The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@archiecobbs archiecobbs marked this pull request as ready for review February 21, 2025 21:45
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 21, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant