7903913: JMH: Compiler profiler misses profiled times #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite CODETOOLS-7903911, compiler profiler still misses the "profiled" times. At this point, I think the problem is the asynchronous nature of compilations: if compiler completes compilation outside of iteration, profiler would miss it.
profiled
is not a great counter, we can replace it with two counters that coverwarmup
andmeasure
phases directly.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/149/head:pull/149
$ git checkout pull/149
Update a local copy of the PR:
$ git checkout pull/149
$ git pull https://git.openjdk.org/jmh.git pull/149/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 149
View PR using the GUI difftool:
$ git pr show -t 149
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/149.diff
Using Webrev
Link to Webrev Comment