Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODETOOLS-7902805: State cycle validation should be more resilient #15

Merged

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Dec 8, 2020

There is a Windows GH Actions test failure on JDK 7.

compileTest(org.openjdk.jmh.ct.states.dag.cycles.ExplicitCycleBenchmarkTest) Time elapsed: 0.383 sec <<< FAILURE!
junit.framework.AssertionFailedError: Failure message should contain "@State dependency cycle is detected", but was "[ERROR at line -1: Annotation generator had thrown the exception. java.lang.InternalError: java.lang.StackOverflowError
   at java.lang.reflect.Proxy.newInstance(Proxy.java:772)
   at java.lang.reflect.Proxy.newProxyInstance(Proxy.java:755)
   at sun.reflect.annotation.AnnotationParser.annotationForMap(AnnotationParser.java:301)
   at com.sun.tools.javac.model.AnnotationProxyMaker.generateAnnotation(AnnotationProxyMaker.java:86)
   at com.sun.tools.javac.model.AnnotationProxyMaker.generateAnnotation(AnnotationProxyMaker.java:78)
   at com.sun.tools.javac.model.JavacElements.getAnnotation(JavacElements.java:108)
   at com.sun.tools.javac.code.Symbol.getAnnotation(Symbol.java:456)
   at org.openjdk.jmh.generators.annotations.APMethodInfo.getAnnotation(APMethodInfo.java:82)
   at org.openjdk.jmh.generators.core.StateObjectHandler.validateNoCyclesStep(StateObjectHandler.java:248)
   at org.openjdk.jmh.generators.core.StateObjectHandler.validateNoCyclesStep(StateObjectHandler.java:249)
   at
...

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Download

$ git fetch https://git.openjdk.java.net/jmh pull/15/head:pull/15
$ git checkout pull/15

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2020
@shipilev shipilev force-pushed the CODETOOLS-7902805-state-cycle-iter branch from 55470dd to ea3bbca Compare December 8, 2020 19:17
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2020

Webrevs

@shipilev shipilev merged commit 2d04177 into openjdk:master Dec 8, 2020
@shipilev shipilev deleted the CODETOOLS-7902805-state-cycle-iter branch December 8, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant