Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903915: JMH: Rebalance tests and test jobs parallelism #151

Merged

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Dec 17, 2024

The ongoing headache with some of the integration tests: some of them effectively test performance, so executing them in parallel introduces flaky failures. We can turn some of those tests serial, but then the testing time would explode on smaller machines, like we have in GHA. We can fix that by rebalancing our GHA test jobs.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • CODETOOLS-7903915: JMH: Rebalance tests and test jobs parallelism (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/151/head:pull/151
$ git checkout pull/151

Update a local copy of the PR:
$ git checkout pull/151
$ git pull https://git.openjdk.org/jmh.git pull/151/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 151

View PR using the GUI difftool:
$ git pr show -t 151

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/151.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title CODETOOLS-7903915: JMH: Rebalance tests and test jobs parallelism 7903915: JMH: Rebalance tests and test jobs parallelism Dec 17, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2024

Webrevs

@shipilev shipilev merged commit 78a947f into openjdk:master Dec 17, 2024
26 of 30 checks passed
@shipilev shipilev deleted the CODETOOLS-7903915-rebalance-parallel branch January 8, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant