fix: don't fork(), exec() and wait(), but just exec() #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change causes the perl process to not hang around during the execution of OpenResty, which is particularly notable when using OpenResty to start something long-running in the foreground. The code for forwarding the signals to the child process has been removed in the process. Signals will be handled by the OpenResty process as normal instead of through the intermediate process that forwards them.
zhuizhuhaomeng
approved these changes
Oct 27, 2023
|
@flrgh pointed out that this change would prevent the cleanup of the temporary prefix directory from happening, which would not be desireable. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes the perl process to not hang around during the execution of OpenResty, which is particularly notable when using OpenResty to start something long-running in the foreground.
The code for forwarding the signals to the child process has been removed in the process. Signals will be handled by the OpenResty process as normal instead of through the intermediate process that forwards them.