Bump xpaas to 1.4.8 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rcernich <[email protected]>
Signed-off-by: rcernich <[email protected]>
Signed-off-by: rcernich <[email protected]>
bparees
reviewed
Jan 25, 2018
| @@ -442,21 +485,30 @@ data: | |||
| docs: https://github.com/jboss-openshift/application-templates/blob/{xpaas_version}/docs/webserver/jws31-tomcat7-postgresql-s2i.adoc | |||
| - location: https://raw.githubusercontent.com/jboss-openshift/application-templates/{xpaas_version}/webserver/jws31-tomcat8-basic-s2i.json | |||
| docs: https://github.com/jboss-openshift/application-templates/blob/{xpaas_version}/docs/webserver/jws31-tomcat8-basic-s2i.adoc | |||
| - location: https://raw.githubusercontent.com/jboss-openshift/application-templates/{xpaas_version}/webserver/jws31-tomcat8-https-s2i.json | |||
| docs: https://github.com/jboss-openshift/application-templates/blob/{xpaas_version}/docs/webserver/jws31-tomcat8-https-s2i.adoc | |||
There was a problem hiding this comment.
this change moved the online-start/pro tags from the "basic" template to this template. intentional?
There was a problem hiding this comment.
Yes. The availability changes were directed by the product managers. @rettori can confirm.
|
ok, lgtm but i'm not the right person to sanity check the actual tag updates... is @rettori the right person to do that? |
|
Probably. I've also asked the product teams to review it. That said, there may be additional PRs, as I don't think all of the PMs provided input to @rettori. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes update the xpaas templates to the latest release and update the list of templates made available on OSO.