OADP-4453: GO-2024-2842 #286
Conversation
Signed-off-by: Tiger Kaovilai <[email protected]> Co-authored-by: Tiger Kaovilai <[email protected]>
Signed-off-by: Tiger Kaovilai <[email protected]> Co-authored-by: Tiger Kaovilai <[email protected]>
Always restore replicaset since in some cross-cluster restore scenarios a newly-deployed replicaset will get a different name, breaking the restored pod. Also, remove MTC-specific RS backup plugin, since the only action there was to mark paused replicasets for restore, which is unnecessary now that we're restoring all of them. Co-authored-by: Scott Seago <[email protected]>
…ault SA do not need it. (openshift#235) * OADP-3598 Dest NS Skip waiting for dockercfg secret if default SA do not need it. Signed-off-by: Tiger Kaovilai <[email protected]> * switch to detecting imageRegistry replicas pending confirmation from slack Signed-off-by: Tiger Kaovilai <[email protected]> * add OCP version check alongside image registry replicas check * remove unused code * modify RestorePlugin struct to add OCP details * directly include WaitForPullSecrets boolean on RestorePlugin struct * fix waitforpullsecrets boolean logic --------- Signed-off-by: Tiger Kaovilai <[email protected]> Co-authored-by: Tiger Kaovilai <[email protected]> Co-authored-by: Shubham Pampattiwar <[email protected]>
Co-authored-by: Shubham Pampattiwar <[email protected]>
…tore plugin (openshift#237) * Update logic to wait for pull secret in pod restore plugin * Update code comments * add logic to check for replicas alongside imageresgitry cluster capability check --------- Co-authored-by: Shubham Pampattiwar <[email protected]>
…shift#240) Signed-off-by: Tiger Kaovilai <[email protected]> Co-authored-by: Tiger Kaovilai <[email protected]>
Co-authored-by: Shubham Pampattiwar <[email protected]>
…ift#273) This contains envParts length fix No longer using kaovilai module name. Signed-off-by: Tiger Kaovilai <[email protected]> Co-authored-by: Tiger Kaovilai <[email protected]>
…t#283) * OADP-3630: Surface errors, Don't send empty env values to registry. Signed-off-by: Tiger Kaovilai <[email protected]> * Use go1.20 experimental slices package slices package were not built-ins until go1.21, and we use go1.20 currently in this branch. See golang/go#57433 Signed-off-by: Tiger Kaovilai <[email protected]> --------- Signed-off-by: Tiger Kaovilai <[email protected]> Co-authored-by: Tiger Kaovilai <[email protected]>
Signed-off-by: Tiger Kaovilai <[email protected]>
openshift-ci-robot
added
the
jira/valid-reference
|
@kaovilai: This pull request references OADP-4453 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-robot
added
the
needs-rebase
|
@kaovilai: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
No description provided.