-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP-4453: GO-2024-2842: bump github.com/containers/image/v5 v5.30.2 #287
Conversation
Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai: No Jira issue with key GO-2024 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
go.mongodb.org/mongo-driver v1.14.0 // indirect | ||
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.45.0 // indirect | ||
go.opentelemetry.io/otel v1.19.0 // indirect | ||
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.19.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to fix
❯ go mod tidy
go: finding module for package go.opentelemetry.io/otel/exporters/otlp/internal
go: github.com/konveyor/openshift-velero-plugin/velero-plugins/imagecopy imports
github.com/containers/image/v5/transports/alltransports imports
github.com/containers/image/v5/docker/daemon imports
github.com/docker/docker/client tested by
github.com/docker/docker/client.test imports
github.com/docker/docker/testutil imports
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp imports
go.opentelemetry.io/otel/exporters/otlp/otlptrace imports
go.opentelemetry.io/otel/exporters/otlp/internal: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using version from go.mod here
https://github.com/containers/image/blob/v5.30.2/go.mod#L133C2-L133C73
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, cleaner than what I was doing. Thank you @kaovilai !
/LGTM
@kaovilai: This pull request references OADP-4453 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, shubham-pampattiwar, sseago, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: Tiger Kaovilai [email protected]