Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2024-3727 oadp-1.4 GO-2024-2842: bump github.com/containers/image… #289

Merged

Conversation

weshayutin
Copy link
Contributor

CVE-2024-3727 oadp-1.4 GO-2024-2842: bump github.com/containers/image/v5 v5.30.2

@openshift-ci-robot
Copy link

@weshayutin: No Jira issue with key GO-2024 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

CVE-2024-3727 oadp-1.4 GO-2024-2842: bump github.com/containers/image/v5 v5.30.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@weshayutin
Copy link
Contributor Author

note:
go mod tidy
go: finding module for package github.com/migtools/udistribution/pkg/image/udistribution
go: finding module for package github.com/moby/docker-image-spec/specs-go/v1
go: found github.com/migtools/udistribution/pkg/image/udistribution in github.com/migtools/udistribution v0.0.6
go: found github.com/moby/docker-image-spec/specs-go/v1 in github.com/moby/docker-image-spec v1.3.1
go: github.com/konveyor/openshift-velero-plugin/velero-plugins/common imports
github.com/migtools/udistribution/pkg/image/udistribution: github.com/migtools/[email protected]: parsing go.mod:
module declares its path as: github.com/kaovilai/udistribution
but was required as: github.com/migtools/udistribution

@openshift-ci openshift-ci bot requested review from eemcmullan and kaovilai October 21, 2024 18:07
github.com/google/go-cmp v0.6.0
github.com/hashicorp/go-hclog v1.0.0 // indirect
github.com/migtools/udistribution v0.0.13-oadp-1.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this dependency being replaced/updated with?

Copy link
Member

@kaovilai kaovilai Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we run

git reset --hard upstream/oadp-1.4 && go get github.com/containers/image/[email protected] && go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected] && go mod tidy

here and this should be good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the migtools/udistribution something we need always manually put back in? It's removed after running go get github.com/containers/image/v5

happy to put it back

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k. see your suggestion.. thank you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran git reset --hard upstream/oadp-1.4 && go get github.com/containers/image/[email protected] && go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected] && go mod tidy

got the same result.. I'll bow out and let someone w/ more chops play here.

@kaovilai kaovilai force-pushed the oadp_14_CVE-2024-3727 branch from 5634b85 to 1d1dacb Compare October 21, 2024 19:09
@kaovilai
Copy link
Member

Had to do essentially

GOTOOLCHAIN=go1.19 go get github.com/containers/image/[email protected] && go get github.com/migtools/[email protected] && go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected] && go mod tidy;

lets see if unit test passes.

@kaovilai kaovilai force-pushed the oadp_14_CVE-2024-3727 branch from 1d1dacb to 1a12533 Compare October 21, 2024 19:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
Copy link

openshift-ci bot commented Oct 21, 2024

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaovilai
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5ce7c26 into openshift:oadp-1.4 Oct 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants