-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVE-2024-3727 oadp-1.4 GO-2024-2842: bump github.com/containers/image… #289
CVE-2024-3727 oadp-1.4 GO-2024-2842: bump github.com/containers/image… #289
Conversation
@weshayutin: No Jira issue with key GO-2024 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
note: |
github.com/google/go-cmp v0.6.0 | ||
github.com/hashicorp/go-hclog v1.0.0 // indirect | ||
github.com/migtools/udistribution v0.0.13-oadp-1.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this dependency being replaced/updated with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we run
git reset --hard upstream/oadp-1.4 && go get github.com/containers/image/[email protected] && go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected] && go mod tidy
here and this should be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the migtools/udistribution something we need always manually put back in? It's removed after running go get github.com/containers/image/v5
happy to put it back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k. see your suggestion.. thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran git reset --hard upstream/oadp-1.4 && go get github.com/containers/image/[email protected] && go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected] && go mod tidy
got the same result.. I'll bow out and let someone w/ more chops play here.
5634b85
to
1d1dacb
Compare
Had to do essentially
lets see if unit test passes. |
…/v5 v5.30.2 Signed-off-by: Wesley Hayutin <[email protected]>
1d1dacb
to
1a12533
Compare
@weshayutin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, shubham-pampattiwar, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
CVE-2024-3727 oadp-1.4 GO-2024-2842: bump github.com/containers/image/v5 v5.30.2