fix(grid): [grid] fix the initial position on the left when dragging …

[gimmyhehe]

…the header to set width

PR

修复当拖拽表头设置宽度时，初始位置偏左问题
修复前：
鼠标按下时，初始位置就比原位置偏左，导致鼠标松开后，列宽比原宽度小一些。

修复后：
初始位置与原位置一致

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

close #2631

Summary by CodeRabbit

• Bug Fixes
  • Improved column resizing behavior in grid component
  • Updated mouse event handling for more accurate drag positioning

The changes focus on refining the user interaction when resizing grid columns, ensuring a more precise and responsive dragging experience.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the header.ts file in the Vue grid package, specifically focusing on the column resizing mechanism. The changes involve updating the resizeMousedown method to use getBoundingClientRect() for calculating drag positions. The approach for determining the left position during column dragging has been refined, with adjustments to how drag boundaries are computed and how mouse event positions are tracked.

Changes

File	Change Summary
packages/vue/src/grid/src/header/src/header.ts	- Removed getOffsetPos utility function import - Updated resizeMousedown method to use getBoundingClientRect() - Introduced btnLeft for calculating drag minimum left position - Simplified drag left position calculation

Possibly related PRs

• fix(grid): [grid] fix selection header disabled error when config che… #2647: Addresses selection header component issues in grid, potentially related to mouse event handling

Suggested labels

bug

Suggested reviewers

• zzcr

Poem

🐰 Resize, oh resize, with grace and might,
Columns dancing left and right so light!
Bounding rectangles now show the way,
Mouse events leap in a computational play,
Grid headers twirl with mathematical delight! 🖱️

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6909756 and 94eb6ed.

📒 Files selected for processing (1)

• packages/vue/src/grid/src/header/src/header.ts (3 hunks)

🔇 Additional comments (6)

packages/vue/src/grid/src/header/src/header.ts (6)

29-29: Looks good—unused import removed.

It appears that the getOffsetPos utility was removed earlier and is no longer needed. This import statement now aligns with the functions currently in use.

---

509-509: Check for potential null references before accessing tableBody.$el.

If tableBody is not set or if there's a scenario where $refs.tableBody might be missing, this line could trigger an error. Consider a null check on tableBody to safeguard against unexpected runtime errors.

---

510-510: Good usage of optional chaining but verify geometry consistency.

Using optional chaining prevents errors if dragBtnElem or $el is null. Verify the bounding rect calculations remain correct if one of the elements is missing, as it could yield invalid offsets.

---

511-511: Ensure minimum drag left is always valid.

By subtracting cell.clientWidth and then adding dragBtnWidth and minInterval, there's a possibility for negative or minimal values if certain conditions arise (e.g., small cell widths). Confirm through testing that dragging remains intuitive and doesn’t cause layout quirks.

---

512-512: Consistency with the fix for initial drag position.

The calculation btnLeft + dragBtnOffsetWidth aligns the drag handle with the pointer's center, ensuring the correct initial drag alignment. This change looks correct and suits the PR’s goal of fixing the offset issue.

---

537-537: Directly assigning dragLeft for clarity.

Retrieving dragLeft from the computed result is straightforward and clear. Keep variable naming consistent throughout the method to maintain readability.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[petercat-assistant]

概述

此PR修复了在拖动表头以设置宽度时，初始位置偏左的问题。修复前，鼠标按下时初始位置比原位置偏左，导致列宽比预期小。修复后，初始位置与原位置一致。

变更

文件	概要
packages/vue/src/grid/src/header/src/header.ts	修复了拖动表头时初始位置偏左的问题，移除了不必要的getOffsetPos调用，改用getBoundingClientRect来计算位置。

[petercat-assistant]

The adjustment of dragLeft calculation by removing dragBtnOffsetWidth seems correct as it aligns the drag start position accurately with the button's position. Ensure that this change does not affect other dependent calculations.

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically.

---

Overview

This PR fixes the issue where the initial position is to the left when dragging the table header to set the width. Before the fix, the initial position when the mouse was pressed was further to the left than the original position, causing the column width to be smaller than expected. After repair, the initial position is consistent with the original position.

Change

Documentation	Summary
packages/vue/src/grid/src/header/src/header.ts	Fixed the problem of the initial position being to the left when dragging the header, removed unnecessary getOffsetPos calls, and used getBoundingClientRect instead Calculate position.