Fix windows build script, prevent fatal crash when a joystick with >64 buttons is connected #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stick initialization (which happens when there is a joystick with more than 64 buttons)
|
Thanks for the PR @tyronx! Seems we've got a build failure on CI, possibly due to pathing issues. Could you try run a local build after running |
|
@tyronx bump |
|
oh, i guess i also have to push the FAKE 4.6x binaries, or rather fix the package restore thing |
|
The travis ci issue does not look like my fault. Some tool is missing/broken there, by the looks of it |
|
Thanks. Will do a merge + release of this for you tomorrow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
As discussed in issue #1020
It is not the most elegant solution, but since no new major features will be added to OpenTK 3.x and stability is of greater importance, probably still a good idea to merge.
Also couldn't build with the default FAKE, had to update to a later version. FAKE apparently had a bug where it didn't recognize the path of the newer .net framework versions.
Testing status