-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #410: Add provider warnings #1123
Conversation
Fixes #751: Deprecate maas/terraform-provider-maas Signed-off-by: AbstractionFactory <[email protected]>
ff316e0
to
8b0810e
Compare
I'll approve but im unsure about this failing check. It looks broken to me. can you look into it please @abstractionfactory ? |
@Yantrio just checked, that one is indeed broken and should be removed. It tries to validate the |
@abstractionfactory Is not just the github action broken for multiple files? This https://github.com/opentofu/registry/actions/runs/11287627799/workflow?pr=1123#L42 should just be
as per examples in actions README https://github.com/tj-actions/changed-files?tab=readme-ov-file#using-local-git-directory- |
@tom-reinders I don't believe so, I checked the verification application and it doesn't actually work when passed a versions endpoint file. |
But the error in the action is trying to open all the files at ones in https://github.com/opentofu/registry/blob/main/src/cmd/validate/main.go#L93. |
This
Does the same as this
Anything in between the |
So it's broken in more than one place. Wonderful. :D |
This comment was marked as duplicate.
This comment was marked as duplicate.
Signed-off-by: ollevche <[email protected]>
GitHub doesn't re-trigger provider validation because the latest commit has no changes to provider paths. Ideally, we would want to show final checks for the diff with the main (or other branch to merge to), because currently it is the way to bypass required validations. Here is the throwaway commit to validate the check run just fine for this particular PR: https://github.com/opentofu/registry/actions/runs/11326232308/job/31494751924 |
If you update the command to accept multiple paths than also update the command call in the GitHub action from
to
to prevent people from making the mistake of thinking that the for loop really works what it does not. |
Signed-off-by: ollevche <[email protected]>
@tom-reinders makes sense! Here is the final run check: https://github.com/opentofu/registry/actions/runs/11326706265/job/31496187527 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds the ability to include warnings for providers. This will translate to the (undocumented) "warnings" field in the V1 API response, which OpenTofu processes. This PR also marks all HashiCorp providers that are archived as deprecated, indicating an official replacement where found/available.
Fixes #410: Add provider warnings
Fixes #751: Deprecate maas/terraform-provider-maas
Related to: opentofu/libregistry#39
Example output in the
versions
response: