-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Siri azure updater refactor #6487
Siri azure updater refactor #6487
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6487 +/- ##
=============================================
+ Coverage 70.10% 70.13% +0.03%
Complexity 18269 18269
=============================================
Files 2077 2077
Lines 77658 77618 -40
Branches 7827 7821 -6
=============================================
- Hits 54439 54438 -1
+ Misses 20441 20403 -38
+ Partials 2778 2777 -1 ☔ View full report in Codecov by Sentry. |
This PR does a solid job of refactoring the Azure updater functionality by clearly separating ET and SX concerns and introducing the new message handler interface. |
61d1136
to
946f006
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does a solid job of refactoring the Azure updater functionality by clearly separating ET and SX concerns and introducing the new message handler interface instead of an abstract class.
d6c64e6
into
opentripplanner:dev-2.x
Summary
This is a refactor of skånetrafiken sandbox siri azure updaters. There is only one trivial change in the non-sandbox code.
Unit tests
This is mostly high level glue code that is hard to test so there are not very many tests. I updated the existing test code.
Bumping the serialization version id
Nope