Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Siri azure updater refactor #6487

Conversation

habrahamsson-skanetrafiken
Copy link
Contributor

Summary

This is a refactor of skånetrafiken sandbox siri azure updaters. There is only one trivial change in the non-sandbox code.

  • Use delegation instead of an abstract base class.
  • Extract most common logic into SiriAzureUpdater and only have a small specific classes for handling ET vs SX.

Unit tests

This is mostly high level glue code that is hard to test so there are not very many tests. I updated the existing test code.

Bumping the serialization version id

Nope

@habrahamsson-skanetrafiken habrahamsson-skanetrafiken requested a review from a team as a code owner February 25, 2025 10:04
@habrahamsson-skanetrafiken habrahamsson-skanetrafiken changed the title Siri azure refactor Siri azure updater refactor Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 7.31707% with 76 lines in your changes missing coverage. Please review.

Project coverage is 70.13%. Comparing base (b9ebbd3) to head (946f006).
Report is 38 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...anner/ext/siri/updater/azure/SiriAzureUpdater.java 12.24% 43 Missing ⚠️
...ner/ext/siri/updater/azure/SiriAzureETUpdater.java 0.00% 10 Missing ⚠️
...ner/ext/siri/updater/azure/SiriAzureSXUpdater.java 0.00% 8 Missing ⚠️
...ri/updater/azure/SiriAzureSXUpdaterParameters.java 0.00% 7 Missing ⚠️
...ri/updater/azure/SiriAzureETUpdaterParameters.java 0.00% 6 Missing ⚠️
...planner/updater/configure/UpdaterConfigurator.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6487      +/-   ##
=============================================
+ Coverage      70.10%   70.13%   +0.03%     
  Complexity     18269    18269              
=============================================
  Files           2077     2077              
  Lines          77658    77618      -40     
  Branches        7827     7821       -6     
=============================================
- Hits           54439    54438       -1     
+ Misses         20441    20403      -38     
+ Partials        2778     2777       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svedbod
Copy link

svedbod commented Feb 25, 2025

This PR does a solid job of refactoring the Azure updater functionality by clearly separating ET and SX concerns and introducing the new message handler interface.

Copy link

@svedbod svedbod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does a solid job of refactoring the Azure updater functionality by clearly separating ET and SX concerns and introducing the new message handler interface instead of an abstract class.

@vpaturet vpaturet self-requested a review February 28, 2025 09:27
@habrahamsson-skanetrafiken habrahamsson-skanetrafiken merged commit d6c64e6 into opentripplanner:dev-2.x Feb 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants