Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add Stateful trait #20

Merged
merged 2 commits into from
Jan 12, 2025
Merged

[feat] Add Stateful trait #20

merged 2 commits into from
Jan 12, 2025

Conversation

nyunyunyunyu
Copy link
Contributor

No description provided.

@nyunyunyunyu nyunyunyunyu force-pushed the feat/state-persist branch 2 times, most recently from a0950c6 to 8005259 Compare January 8, 2025 16:37
@nyunyunyunyu nyunyunyunyu marked this pull request as ready for review January 8, 2025 16:37
jonathanpwang
jonathanpwang reviewed Jan 8, 2025
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
jonathanpwang
jonathanpwang approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trait seems fine, let's discuss naming a little

@jonathanpwang jonathanpwang changed the title [feat] Add PersistStateChip trait [feat] Add Stateful trait Jan 9, 2025
@jonathanpwang
Copy link
Contributor

@nyunyunyunyu merge?

@jonathanpwang
Copy link
Contributor

hmm @nyunyunyunyu I wonder if we want load_state to take in a deserializer so we don't require global changes to switch bincode to bitcode etc?

jonathanpwang
jonathanpwang reviewed Jan 9, 2025
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@jonathanpwang jonathanpwang mentioned this pull request Jan 10, 2025
Merged
@nyunyunyunyu nyunyunyunyu merged commit 25265e7 into main Jan 12, 2025
3 checks passed
@nyunyunyunyu nyunyunyunyu deleted the feat/state-persist branch January 12, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

@luffykai luffykai Awaiting requested review from luffykai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyunyunyunyu @jonathanpwang