Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python API: Python translation for NodeNotReachableException #355

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

redlicha
Copy link
Member

@redlicha redlicha commented Sep 13, 2017

Addresses #349

Before:

In [9]: client.list_volumes("node_1")
Out[9]: []

In [10]: !fusermount -u /tmp/RemoteTest/remote/mnt

In [11]: client.list_volumes("node_1")
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
<ipython-input-11-1396f3ceb850> in <module>()
----> 1 client.list_volumes("node_1")

RuntimeError: failed to send XMLRPC request volumesList

After:

In [4]: client.list_volumes("node_1")
Out[4]: []

In [5]: !fusermount -u /tmp/RemoteTest/remote/mnt

In [6]: client.list_volumes("node_1")
---------------------------------------------------------------------------
NodeNotReachableException                 Traceback (most recent call last)
<ipython-input-6-1396f3ceb850> in <module>()
----> 1 client.list_volumes("node_1")

NodeNotReachableException: failed to send XMLRPC request volumesList

CC @kvanhijf , @JeffreyDevloo : is that sufficient for the fwk's purposes (keeping in mind that ClusterNotReachableException could also be raised in other cases)?

@JeffreyDevloo
Copy link

Could you provide us the path to import this exception from?

@redlicha
Copy link
Member Author

@JeffreyDevloo : it's under volumedriver.storagerouter.storagerouterclient.

@cnanakos cnanakos self-requested a review September 13, 2017 13:51
@redlicha redlicha merged commit 9b9e1d4 into dev Sep 21, 2017
@redlicha redlicha deleted the feature/translate-node-not-reachable-to-python branch November 2, 2017 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants