Feature/move toolcut into python api dso #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
October 30, 2017 15:26
Loosely part of #365
Loosely related to #365
Loosely related to #365
python/LoggingAdapter (nee LoggerToolCut) provides the same functionality. Loosely related to #365
youtils::python::BuildInfoAdapter provides the same functionality. Loosely related to #365
…lvolumedriver The ToolCut helpers themselves should be revisited at a later point as there's potential for cleanups / removal of wrappers in favour of binding the wrapped types directly. Part of #365
This moves the remaining functionality (Python bindings) out of the ToolCut module definition in the ToolCut DSO so it can be reused in the storagerouterclient DSO. Part of #365
Previously this was done in each module before registering the LoggingAdapter which could lead to logging being switched off again after being configured. Part of #365
This factors out the SCO binding from volumedriverfs::python::MDSClient and replaces SCOToolCut with it. Part of #365
This factors out the ClusterLocation binding from volumedriverfs::python::MDSClient and replaces ClusterLocationToolCut with it. Part of #365
This factors out the ClusterLocationAndHash binding from volumedriverfs::python::MDSClient. Part of #365
…ects These were wrappers that retrieved objects from the backend to a tmp file and then constructed from the latter, which can be reimplemented purely in Python. Part of #365
cnanakos
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #365 by moving the
ToolCutfunctionality into the Python API DSO (storagerouterclient) and making it available under_debug.This requires some auxiliary changes such as making the internal interfaces resilient towards multiple registrations of converters (the alternative would be making sure a converter is only ever registered once) otherwise importing the module would fail at runtime.
ToolCutis hollowed out by moving the actual bindings tovolumedriver/pythonand only leaving a thin wrapper in place that is used to still build the existing DSO. The bindings involumedriver/pythonare also used when building thestoragerouterclientDSO.TBD (in a subsequent PR?): streamline the
filesystem-python-clientdirectory in a similar fashion, i.e. move the actual adapters tofilesystem/python(some should be moved tovolumedriver/python) and only pick the relevant pieces from there to buildstoragerouterclient.