[GR-61722] Fix last dacapo warmup iteration having the wrong iteration number #10614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For N iterations, dacapo runs N-1 warmup iterations, which print 'completed warmup X', as well as a final iteration, which prints 'PASSED'. The 'warmup' metric should capture all those values in order. Before, it had a separate rule to capture the pattern using 'PASSED' for the warmup, which used totalIterations (the value passed to -n) to determine what the iteration of that measurement is supposed to be. Using the number passed to -n to determine what number the last iteration should be is fragile beause that captures the orgininal -n value and not the replaced -n value for agent and instrumentation runs.
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.