Remove remote slashing protection feature (#12989)

* Remove remote slashing protection feature

* test fix

* remove mock from tests

---------

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>

beacon-chain/slasher/BUILD.bazel

@@ -74,7 +74,6 @@ go_test(
         "//beacon-chain/db/testing:go_default_library",
         "//beacon-chain/forkchoice/doubly-linked-tree:go_default_library",
         "//beacon-chain/operations/slashings/mock:go_default_library",
-        "//beacon-chain/slasher/mock:go_default_library",
         "//beacon-chain/slasher/types:go_default_library",
         "//beacon-chain/startup:go_default_library",
         "//beacon-chain/state/stategen:go_default_library",

beacon-chain/slasher/service_test.go

@@ -9,7 +9,6 @@ import (
 	"github.com/prysmaticlabs/prysm/v4/async/event"
 	mock "github.com/prysmaticlabs/prysm/v4/beacon-chain/blockchain/testing"
 	dbtest "github.com/prysmaticlabs/prysm/v4/beacon-chain/db/testing"
-	mockslasher "github.com/prysmaticlabs/prysm/v4/beacon-chain/slasher/mock"
 	"github.com/prysmaticlabs/prysm/v4/beacon-chain/startup"
 	mockSync "github.com/prysmaticlabs/prysm/v4/beacon-chain/sync/initial-sync/testing"
 	"github.com/prysmaticlabs/prysm/v4/consensus-types/primitives"
@@ -21,7 +20,6 @@ import (
 )
 
 var _ = SlashingChecker(&Service{})
-var _ = SlashingChecker(&mockslasher.MockSlashingChecker{})
 
 func TestMain(m *testing.M) {
 	logrus.SetLevel(logrus.DebugLevel)

config/features/config.go

@@ -37,7 +37,6 @@ const disabledFeatureFlag = "Disabled feature flag"
 // Flags is a struct to represent which features the client will perform on runtime.
 type Flags struct {
 	// Feature related flags.
-	RemoteSlasherProtection             bool // RemoteSlasherProtection utilizes a beacon node with --slasher mode for validator slashing protection.
 	WriteSSZStateTransitions            bool // WriteSSZStateTransitions to tmp directory.
 	EnablePeerScorer                    bool // EnablePeerScorer enables experimental peer scoring in p2p.
 	DisableReorgLateBlocks              bool // DisableReorgLateBlocks disables reorgs of late blocks.
@@ -269,12 +268,6 @@ func ConfigureValidator(ctx *cli.Context) error {
 	if err := configureTestnet(ctx); err != nil {
 		return err
 	}
-	if ctx.Bool(enableExternalSlasherProtectionFlag.Name) {
-		log.Fatal(
-			"Remote slashing protection has currently been disabled in Prysm due to safety concerns. " +
-				"We appreciate your understanding in our desire to keep Prysm validators safe.",
-		)
-	}
 	if ctx.Bool(writeWalletPasswordOnWebOnboarding.Name) {
 		logEnabled(writeWalletPasswordOnWebOnboarding)
 		cfg.WriteWalletPasswordOnWebOnboarding = true

config/features/config_test.go

@@ -17,10 +17,6 @@ func TestInitFeatureConfig(t *testing.T) {
 	Init(cfg)
 	c := Get()
 	assert.Equal(t, true, c.EnableSlasher)
-
-	// Reset back to false for the follow up tests.
-	cfg = &Flags{RemoteSlasherProtection: false}
-	Init(cfg)
 }
 
 func TestInitWithReset(t *testing.T) {