backpress,onItemClickListener #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
orhanobut
commented
Jan 20, 2015
orhanobut
commented
- Back press issue is fixed
- OnItemClickListener has changed, now it has dialog object too.
- Default holder is ListHolder now.
| @@ -195,7 +198,6 @@ private void createDialog() { | |||
| initCancellable(); | |||
There was a problem hiding this comment.
initCancelable(); I think there's one more "l"
|
Very nice. So finally is the container that needs to have the keyListener :) really good find! I only found this small thing and then we can merge. |
AlexBalo
added a commit
that referenced
this pull request
Jan 21, 2015
backpress,onItemClickListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.