Tags: orisano/mysql-shell
Tags
BUG#28915716 MEMSET IS NOT A PROPER FUNCTION TO ERASE SENSITIVE DATA The buffers used to temporarily store the passwords obtained from the user were not being properly cleaned, in some cases memset was being used to "cleanup" the buffers and in other cases not even that. memset may be optimized away (under the as-if rules) if the object modified by this function is not accessed again for the rest of its lifetime, letting the password data available in the memory buffer. This patch replaces memset with functions that are excluded by this optimization, explicit_bzero in linux and SecureZeroMemory in windows eliminating the potential risk. Change-Id: Ia5c401db5d9eaea3f8e2b31aabc922930a08f2c8
BUG#27677227 SILENT ASSUMPTION WHEN CONFIGURING CLUSTER WITH X PROTOC… …OL DISABLED When a cluster is created on a server that doesn't have the X Plugin enabled, a silent assumption is made about the X Protocol port value. The port value is calculated based on a default assumption that the X Protocol port is equal to value of the classic protocol * 10. Such value in stored in the metadata schema under the addresses column of the instances table, having the value of 'mysqlX'. Such assumption cannot be done and the address information related to the X Protocol should only be stored under 'mysqlX' if the protocol is enabled. This patch fixes the issue by making sure that the value of 'mysqlX' is only stored for instances on which the X Protocol is enabled. Otherwise no value is stored. Added unit-tests for regression. Change-Id: I4081eaf2f83dbe83682663b13f8d3777df9d5d0b (cherry picked from commit e361a44c5197ac2c3767a2cbaa5ff62510766517)
Bug #28242573 MYSQLSH NOT DISPLAYING THE BUILD TYPE (COMMERCIAL) AS P… …ART OF THE VERSION INFO The version info has been updated to properly display the build type as part of the version info on the missed use cases: - The banner printed when the shell is started - The banner printed when the --help argument is used Change-Id: Ia09f400b059f8752bf1fd057def8c3ad1817592b (cherry picked from commit 47e824bc58e7091cfebdd0de3cbaa098e5939eb1)
BUG#27809310: SHELL.GETSESSION() CAUSES CRASH IF NO SESSION IS ESTABL… …ISHED A crash was generated when the function was called and no session was established. The problem is that when a null object is assigned to a Value, it still indicates it is an object and when attempting to translate the value to JS/PY it crashes. The fix consist on adding validation to the Value constructor to make it set the type to NULL if the assigned object is Null. (cherry picked from commit 8e1858b65f71e42ee8f4fe342a6240fbcb69d159)
Fixed Windows test failures: Command_line_test.bug24905066 is failing on windows because the Shell is not recognizing the named-pipe identifier (.) as equivalent to 'localhost'. A possible solution would be to use 'localhost' but this actually needs to be fixed in the shell. Shell_js_dba_tests.configure_local_instance is failing on windows because of a wrong log validation which is expecting the string "mysqlprovisioning" instead of "mysqlprovisioning.zip" Shell_js_dba_tests.dba_cluster_add_instance is failing on windows because of a wrong path splitting logic.
- Added "/usr/share/mysqlsh/prompt/" to the Deb packages - Exclude the "include" directory from Deb packages - Made the Deb build fail if not all installed files are packaged - Minor changes to the RPM and Deb specification to remove the "include" and "lib" directory, if exists, before starting packaging
Bug# 26431908: SHELL UNABLE TO RETRIEVE DB INFORMATION THROUGH AND X … …SESSION USING SSL Synchronized mysqlxtest to the level of 5.7.14 on the server Updated mysqlxtest to use violite library for SSL communications Fixed passing of SSL parameters for connections through the X Protocol Fixed \s status command to properly display the cipher being used in both protocols Refactoring X protocol connection functions: moved from SessionHandle to the lower level Session class in mysqlxtest Cleaned up AdminAPI code using constants defined in mysqlxtest Removed unrequired code from mysqlxtest
PreviousNext