feat: Added the ability to pass a StringFormat type resolver, so that… #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it is possible to pass custom Scalar types to represent different format values.
|
Hello thanks for the contribution. What do you think about doing the same thing as we already do for mocks maybe? |
…ing resolver function in config
Sorry I had a look at mocks and not entirely sure what you mean here? Would you be able to elaborate? Happy to update if you could add some guidance on a better approach. |
|
Looks like you have a merge conflict |
|
what do you think as doing like for the mock have an property in the config format?: Record<string, unknown>; and when it match a hint just replace the type with that one |
|
Would love to help out where I can here since I need this same change soon. Any good place for me to start? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
WIP
Description
Implement a type resolver for strings that also have a format hint
Fix #1383
Todos
Steps to Test or Reproduce
Need to write tests