Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject console parameters in GRUB2 #20340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Copy link

github-actions bot commented Oct 4, 2024

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@mloviska mloviska force-pushed the grub2_inject_console branch 5 times, most recently from 1437f54 to 8fbbf53 Compare October 4, 2024 10:30
@mloviska mloviska marked this pull request as ready for review October 4, 2024 10:42
@Vogtinator
Copy link
Member

If the graphical console is no longer used by the kernel at all that's a severe product bug and IMO a ship stopper.

Copy link
Contributor

@pablo-herranz pablo-herranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit, although I do not like all that blind up-down fixed movements... Wouldn't it be adequate to check if the selected option is the correct before accepting?

@mloviska
Copy link
Contributor Author

mloviska commented Oct 4, 2024

Seems legit, although I do not like all that blind up-down fixed movements... Wouldn't it be adequate to check if the selected option is the correct before accepting?

The emacs like shortcuts are insufficient for our needs, so the navigation options in the submenu is very limited. At most we can add more needles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants