Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pre-commit / make lint #39

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

schuellerf
Copy link
Contributor

Introduce pre-commit linting with make lint.
Also add this to github actions.

Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is very nice and I love that I will be able to do "make lint" now :) Tiny suggestion/question about what commit should introduce what files but otherwise great stuff.

.golangci.yml Show resolved Hide resolved
.pylintrc Show resolved Hide resolved
.yamllint Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
test/.pylintrc Show resolved Hide resolved
tools/.pylintrc Show resolved Hide resolved
@schuellerf schuellerf force-pushed the introduce-pre-commit-lint branch from 0c5ee66 to 09e9992 Compare January 7, 2025 09:59
Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you!

@schuellerf schuellerf added this pull request to the merge queue Jan 7, 2025
Merged via the queue into osbuild:main with commit c408577 Jan 7, 2025
2 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants