-
Notifications
You must be signed in to change notification settings - Fork 339
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
c7848d4
commit 0093be4
Showing
1 changed file
with
11 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0093be4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Conejo,
I think it would be better to move strip_slashes_extended_e() inside [
corrected
] utils.php below existing strip_slashes_extended() ?0093be4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I do not see any difference between already existing function ?
0093be4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function is the same as strip_slahes_extended and it's only there to avoid loading more files (as the error could happen when there's no lib loaded yet). We'll be dropping 5.4 support in next version, since it's officially unsupported.
strip_slashes_extended_e will only be called if you use an unsupported PHP version 5.3 ("dead" on August 2014) or older AND you have to set the magic quotes to ON (by default they are enabled). After 5.4 (5.4 included), get_magic_quotes_gpc will return false as it was removed and the function will not be needed.
0093be4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for the explanation, I suspected it wasn't without a reason :)
0093be4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If was a quick and dirty fix, we will stop supporting 5.4 and previous version in future releases (not sure how will do that yet)
0093be4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know... you announced this @ forums few weeks ago, not sure if it will be "welcomed" by some users on older PHP versions.
Some users had issues when switching to 5.5 probably due very old plugins:
http://forums.osclass.org/plugins-20/finally-social-media-auto-poster-plugin-for-osclass-is-ready-30840/msg131067/#msg131067
But there shouldn't be any major issues past 5.5 now.