Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Email Confirmation for Registration #30

Closed
NeuralFlux opened this issue May 8, 2019 · 7 comments
Closed

Add Email Confirmation for Registration #30

NeuralFlux opened this issue May 8, 2019 · 7 comments
Assignees
@bvishal8510 @ayush1999guptA
Labels
enhancement New feature or request help wanted Extra attention is needed SoI19

Comments

@NeuralFlux
Copy link
Member

NeuralFlux commented May 8, 2019 •
edited
Loading

After #15 and #29 are completed, add an email confirmation feature to the registration procedure, to further filter the spam.

  • So when a user registers, he should be shown a page saying "An email has been sent to your email ID, kindly go to that URL to confirm your account".
  • If someone comes with an invalid link, display "There was some error validating this account, kindly try again"
  • If someone comes with a proper link, display "Your account has been activated!" and activate their account.

A few points to keep in mind while implementing this:

  • A user can login only if an attribute is_active is True. So if the verification fails, set this to False. Else, set it to True.
@NeuralFlux NeuralFlux added enhancement New feature or request good first issue Good for newcomers SoI19 labels May 8, 2019
@NeuralFlux NeuralFlux added help wanted Extra attention is needed and removed good first issue Good for newcomers labels May 8, 2019
@ayush1999guptA ayush1999guptA mentioned this issue May 9, 2019
Merged
3 tasks
@ayush1999guptA
Copy link
Member

Can I have this issue?

@NeuralFlux
Copy link
Member Author

Sure

@bvishal8510
Copy link
Contributor

@NeuralFlux is someone still working on this issue? If not may I work on this?

@NeuralFlux
Copy link
Member Author

NeuralFlux commented Jul 10, 2019 •
edited
Loading

@NeuralFlux is someone still working on this issue? If not may I work on this?

Hey, I assigned it to you. Thanks for taking it up!

@sarthakvijayvergiya
Copy link

@NeuralFlux is someone still working on this issue? If not may I work on this?

@bvishal8510
Copy link
Contributor

@sarthakvijayvergiya I am working on this. You may take up any other issue.

@bvishal8510 bvishal8510 mentioned this issue Jul 23, 2019
Merged
@svp19
Copy link
Member

svp19 commented Jul 27, 2019

Issue resolved

@svp19 svp19 closed this as completed Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvishal8510 bvishal8510

@ayush1999guptA ayush1999guptA

Labels
enhancement New feature or request help wanted Extra attention is needed SoI19
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sarthakvijayvergiya @bvishal8510 @NeuralFlux @ayush1999guptA @svp19