-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
view for user Registration created #33
Conversation
May I know what's the difference in between this PR and the previous PR, and why did you close it? |
Also, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try and validate the email better? Better as in, the current form only checks for the syntax of the email address, whereas, the better one should actually check if the address exists. There are many Python packages to do this, can you try looking into it?
Hello @ayush1999guptA! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-05-09 15:21:50 UTC |
Sorry I forgot to push my changes |
Great work on the registration and validation of emails there! But the email registration wasn't how it was supposed to be. So I removed it from this PR message. I'll just update the issue to make it clearer about what's to be done. |
Changes Summary: Created a new Register view which provides the functionality to register user and also changed the login template. In order to validate the email I have added 2 dependencies:- py3dns==3.2.0
validate-email==1.3
which I have added to the requirements.txt file