Merge pull request ceph#4882 from SUSE/wip-submitting-patches-clarifi…

…cation SubmittingPatches: clarify how Reviewed-by lines are added Reviewed-by: Sage Weil <[email protected]>
osynge · Jun 6, 2015 · efededa · efededa
2 parents eefdeb6 + 85b327f
commit efededa
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/SubmittingPatches b/SubmittingPatches
@@ -273,6 +273,15 @@ A: The target branch depends on the nature of your change:
    you are fixing a bug that exists on the "firefly" branch and that you
    desire that your change be cherry-picked to that branch.
 
+Q: How to include Reviewed-by: tag(s) in my pull request?
+
+   You don't. If someone reviews your pull request, they should indicate they
+   have done so by commenting on it with "+1", "looks good to me", "LGTM",
+   and/or the entire "Reviewed-by: ..." line with their name and email address.
+
+   The developer merging the pull request should note positive reviews and
+   include the appropriate Reviewed-by: lines in the merge commit.
+
 2) Patch submission via [email protected]
 
 The best way to generate a patch for manual submission is to work from