Allow module without Helper/HelperFactory (joomla#40017)

ot2sen · Mar 10, 2023 · e1c9bf3 · e1c9bf3
1 parent 15dfdfb
commit e1c9bf3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/libraries/src/Extension/Module.php b/libraries/src/Extension/Module.php
@@ -53,7 +53,7 @@ class Module implements ModuleInterface, HelperFactoryInterface
      *
      * @since   4.0.0
      */
-    public function __construct(ModuleDispatcherFactoryInterface $dispatcherFactory, HelperFactoryInterface $helperFactory)
+    public function __construct(ModuleDispatcherFactoryInterface $dispatcherFactory, ?HelperFactoryInterface $helperFactory)
     {
         $this->dispatcherFactory = $dispatcherFactory;
         $this->helperFactory     = $helperFactory;

diff --git a/libraries/src/Extension/Service/Provider/Module.php b/libraries/src/Extension/Service/Provider/Module.php
@@ -42,7 +42,7 @@ public function register(Container $container)
             function (Container $container) {
                 return new \Joomla\CMS\Extension\Module(
                     $container->get(ModuleDispatcherFactoryInterface::class),
-                    $container->get(HelperFactoryInterface::class)
+                    $container->has(HelperFactoryInterface::class) ? $container->get(HelperFactoryInterface::class) : null
                 );
             }
         );