Revert "修复kafka消费回滚的bug (alibaba#2521)" (alibaba#2526)

This reverts commit 31acfc0.
oukenwang · Jan 2, 2020 · b6333f0 · b6333f0
1 parent 31acfc0
commit b6333f0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 20 deletions.
diff --git a/...main/java/com/alibaba/otter/canal/adapter/launcher/loader/AbstractCanalAdapterWorker.java b/...main/java/com/alibaba/otter/canal/adapter/launcher/loader/AbstractCanalAdapterWorker.java
@@ -174,11 +174,6 @@ protected boolean mqWriteOutData(int retry, long timeout, int i, final boolean f
             if (i == retry - 1) {
                 connector.ack();
                 logger.error(e.getMessage() + " Error sync but ACK!");
-                try {
-                    Thread.sleep(500);
-                } catch (InterruptedException e1) {
-                    // ignore
-                }
                 return true;
             } else {
                 connector.rollback();

diff --git a/client/src/main/java/com/alibaba/otter/canal/client/kafka/KafkaCanalConnector.java b/client/src/main/java/com/alibaba/otter/canal/client/kafka/KafkaCanalConnector.java
@@ -61,11 +61,11 @@ public KafkaCanalConnector(String servers, String topic, Integer partition, Stri
             batchSize = 100;
         }
         properties.put("max.poll.records", batchSize.toString());
-        properties.put("key.deserializer", StringDeserializer.class);
+        properties.put("key.deserializer", StringDeserializer.class.getName());
         if (!flatMessage) {
-            properties.put("value.deserializer", MessageDeserializer.class);
+            properties.put("value.deserializer", MessageDeserializer.class.getName());
         } else {
-            properties.put("value.deserializer", StringDeserializer.class);
+            properties.put("value.deserializer", StringDeserializer.class.getName());
         }
     }
 
@@ -183,13 +183,14 @@ public List<Message> getListWithoutAck(Long timeout, TimeUnit unit) throws Canal
 
         ConsumerRecords<String, Message> records = kafkaConsumer.poll(unit.toMillis(timeout));
 
+        currentOffsets.clear();
+        for (TopicPartition topicPartition : records.partitions()) {
+            currentOffsets.put(topicPartition.partition(), kafkaConsumer.position(topicPartition));
+        }
+
         if (!records.isEmpty()) {
-            currentOffsets.clear();
             List<Message> messages = new ArrayList<>();
             for (ConsumerRecord<String, Message> record : records) {
-                if (currentOffsets.get(record.partition()) == null) {
-                    currentOffsets.put(record.partition(), record.offset());
-                }
                 messages.add(record.value());
             }
             return messages;
@@ -220,13 +221,14 @@ public List<FlatMessage> getFlatListWithoutAck(Long timeout, TimeUnit unit) thro
 
         ConsumerRecords<String, String> records = kafkaConsumer2.poll(unit.toMillis(timeout));
 
+        currentOffsets.clear();
+        for (TopicPartition topicPartition : records.partitions()) {
+            currentOffsets.put(topicPartition.partition(), kafkaConsumer2.position(topicPartition));
+        }
+
         if (!records.isEmpty()) {
-            currentOffsets.clear();
             List<FlatMessage> flatMessages = new ArrayList<>();
             for (ConsumerRecord<String, String> record : records) {
-                if (currentOffsets.get(record.partition()) == null) {
-                    currentOffsets.put(record.partition(), record.offset());
-                }
                 String flatMessageJson = record.value();
                 FlatMessage flatMessage = JSON.parseObject(flatMessageJson, FlatMessage.class);
                 flatMessages.add(flatMessage);
@@ -246,14 +248,12 @@ public void rollback() {
         // 回滚所有分区
         if (kafkaConsumer != null) {
             for (Map.Entry<Integer, Long> entry : currentOffsets.entrySet()) {
-                kafkaConsumer.seek(new TopicPartition(topic, entry.getKey()), currentOffsets.get(entry.getKey()));
-                kafkaConsumer.commitSync();
+                kafkaConsumer.seek(new TopicPartition(topic, entry.getKey()), entry.getValue() - 1);
             }
         }
         if (kafkaConsumer2 != null) {
             for (Map.Entry<Integer, Long> entry : currentOffsets.entrySet()) {
-                kafkaConsumer2.seek(new TopicPartition(topic, entry.getKey()), currentOffsets.get(entry.getKey()));
-                kafkaConsumer.commitSync();
+                kafkaConsumer2.seek(new TopicPartition(topic, entry.getKey()), entry.getValue() - 1);
             }
         }
     }