Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java code generation fixes #809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Java code generation fixes #809

wants to merge 1 commit into from

Conversation

ChristineZh0u
Copy link
Contributor

  • Reverted PEvent Java code generation bug introduced in P Checker clean up
  • Added the JEvent case to the existing handling of immutable types (like JString and JEnum)
  • Changed the default value for JEvent to be null

@lewisbru
Copy link
Contributor

This looks correct (per my local changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankushdesai ankushdesai Awaiting requested review from ankushdesai

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristineZh0u @lewisbru