Fix .pc description and url #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix .pc description and url. PROJECT_DESCRIPTION and PROJECT_URL are not set in the project command so they evaluate to nothing. csv2 requires CMake 3.8 but setting HOMEPAGE_URL in the project command is only available in CMake 3.12 and later and the variables seem to only be used in the .pc file so set the values instead of using substitution.
p-ranav
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix .pc description and url.
PROJECT_DESCRIPTION and PROJECT_URL are
not set in the project command so they evaluate to nothing.
csv2 requires CMake 3.8 but setting HOMEPAGE_URL in
the project command is only available in CMake 3.12 and later
and the variables seem to only be used in the .pc file so
set the values instead of using substitution.