Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include and CMake option #33

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

Facon
Copy link

@Facon Facon commented Sep 16, 2022

Hello,

I am considering using this in a professional project. I notice that some small improvements are needed for this nice library.

First, on Linux with gcc, all warnings and pedantic activated. I get the following error about a missing iterator header.

Also, I tried to compile the tests, but the option is not properly linked to the test folders.

With this pull request, both issues should be fixed.

@p-ranav p-ranav merged commit 070e9cc into p-ranav:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants