[enhancement] Add typing hints for most functions, which makes it easier to use IDEs for programming

[rtpt-romankarwacik]

I added typing hints for most functions, which makes it easier to use IDEs for programming.

[p0dalirius]

Hey,

Thank you for this PR. I am not really sure to understand the usecase for this? Can you explain it in more details?

As of now, the code does not pass the linting in my Actions:

https://github.com/p0dalirius/smbclient-ng/actions/runs/12029054251/job/33536128360?pr=117

Run # stop the build if there are Python syntax errors or undefined names
./smbclientng/core/utils.py:460:61: F821 undefined name 'Tuple'
def is_port_open(target: str, port: int, timeout: float) -> Tuple[bool, Optional[str]]:
                                                            ^
1     F821 undefined name 'Tuple'

Can you fix this?

Best regards,

[rtpt-romankarwacik]

I am not really sure to understand the usecase for this? Can you explain it in more details?

VSCode and other IDEs can use the types to give hints about the used variables and functions, and can sometimes highlight if None type checks are missing and similar cases, for example:

Although impacket does not have much typing, it can help to see the arguments needed of functions without having to look them up manually.

from __future__ import annotations

is needed to not have to put the type annotations in strings, and

from typing import TYPE_CHECKING

if TYPE_CHECKING:

is needed to avoid circular imports when using typing hints.

[p0dalirius]

Thank you for the very clear explanation!

Merging,