Update ansible-list

Tackle (don't skip) the warnings.

.ansible-lint

@@ -2,11 +2,8 @@
 
 exclude_paths:
   - zuul.d/secret-sflogs.yaml
-
-skip_list:
-  - missing-import  # in playbooks/base/ we import roles not from this repo
-  - role-name  # we're not going to publish the roles
-  - unnamed-task  # pretty strict
+  # {pre|post}.yaml import roles not from this repo
+  - playbooks/base/
 
 mock_modules:
   # Silence for F35, move to ansible.posix.selinux since F36

.pre-commit-config.yaml

@@ -8,16 +8,16 @@ repos:
     hooks:
       - id: prettier
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.3.0
+    rev: v4.4.0
     hooks:
       - id: check-added-large-files
       - id: check-merge-conflict
       #    - id: check-yaml
       - id: detect-private-key
       - id: end-of-file-fixer
       - id: trailing-whitespace
-  - repo: https://github.com/willthames/ansible-lint.git
-    rev: v6.3.0
+  - repo: https://github.com/ansible/ansible-lint.git
+    rev: v6.17.2
     hooks:
       - id: ansible-lint
         files: \.(yaml|yml)$

playbooks/base/pre.yaml

@@ -16,7 +16,7 @@
       when: "ansible_connection != 'kubectl'"
     - block:
         - include_role: name=prepare-workspace-openshift
-        - include_role: name=remove-zuul-sshkey
+        - include_role: name=remove_zuul_sshkey
       run_once: true
       when: "ansible_connection == 'kubectl'"
     - import_role: name=ensure-output-dirs

playbooks/linters/run.yaml

@@ -1,4 +1,5 @@
 ---
-- hosts: all
+- name: Run linters
+  hosts: all
   roles:
     - linters

playbooks/oc-cluster-up.yaml

@@ -1,4 +1,5 @@
 ---
-- hosts: all
+- name: Run oc_cluster_up
+  hosts: all
   roles:
-    - oc-cluster-up
+    - oc_cluster_up

playbooks/pre-commit.yaml

@@ -1,4 +1,5 @@
 ---
-- hosts: all
+- name: Run pre_commit
+  hosts: all
   roles:
-    - pre-commit
+    - pre_commit

roles/linters/tasks/main.yaml

@@ -3,7 +3,8 @@
   ansible.builtin.set_fact:
     linter_failure: false
 
-- include: "lint_{{ item }}.yaml"
+- name: Include linter tasks
+  ansible.builtin.include_tasks: "lint_{{ item }}.yaml"
   loop: "{{ linters }}"
 
 - name: Fail if one linter failed

roles/oc-cluster-up/tasks/main.yml → roles/oc_cluster_up/tasks/main.yml

@@ -9,7 +9,7 @@
   ansible.builtin.get_url:
     url: https://download.docker.com/linux/centos/docker-ce.repo
     dest: /etc/yum.repos.d/docker-ce.repo
-    mode: 0644
+    mode: "0644"
   become: true
 
 - name: Install Docker CE
@@ -42,7 +42,7 @@
     line: |
       {"insecure-registries" : [ "172.30.0.0/16" ]}
     create: true
-    mode: 0644
+    mode: "0644"
   become: true
 
 - name: Make sure docker is running