-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug/Refactor] Block moves that shouldn't be selectable under certain conditions, refactor Gravity #3520
Draft
schmidtc1
wants to merge
20
commits into
pagefaultgames:beta
Choose a base branch
from
schmidtc1:blockmoves
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidtc1
commented
Aug 13, 2024
10 tasks
…fore they are called
Seems like there might be overlap with #2051 in functionality? |
Wasn't aware of that PR, looks like a decent amount of overlap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
Some moves shouldn't be selectable in the move menu under certain conditions.
Refactors Gravity and the Interrupted tag.
Why am I doing these changes?
It is the correct implementation of the moves.
What did change?
Adds
UnselectableMoveAttr
to the following moves:Adds a check in
isUsable()
for determining if a move can be selected.Adds a check in
MovePhase
for displaying the failed text specific to these moves.Removes the
lapse()
function fromInterruptedTag
. All functionality moved toonAdd()
and tag is removed immediately after.(NOTE: debating whether Interrupted tag should just be removed and place functionality in move.ts as an attribute of Gravity, Smack Down, and Thousand Arrows.)
Screenshots/Videos
Stuff cheeks
Stuff.cheeks.blocked.mp4
Gravity moves
Gravity.moves.mp4
Struggle when no moves are usable
Struggle.with.no.usable.moves.mp4
Semi-invulnerable airborne moves cancelled before second turn goes off
Fly.cancelled.mp4
To-do
How to test the changes?
Checklist
beta
as my base branchnpm run test
)