Fix [BUG] #5081 Wrong visual text when using priority moves on Psychic Terrain

[KennethWest]

What are the changes the user will see?

When battling on Psychic Terrain the user will now get battle text that properly reflects which Pokémon was protected from a priority move blocked by the terrain.

Why am I making these changes?

Currently the text says the user of the move is protected by the Psychic Terrain, that can be confusing for players. More over it withholds information from the player about which Pokémon is being targeted by the opponent in double battles.

Fixes #5081

What are the changes from a developer perspective?

All changes occurred in src/phases/move-phase.ts. Changed the arguments passed to the function getTerrainBlockMessage().
Previously the argument list was:
getTerrainBlockMessage(this.pokemon, this.scene.arena.getTerrainType()) which would pass the Pokémon that used the move along to rather that the target of the move.
It was changed to:
getTerrainBlockMessage(targets[0], this.scene.arena.getTerrainType()).

Screenshots/Videos

Before:

Psychic.Terrain.Text.Bug.mp4

After:

FixedPsychicTerrainVisualText.mp4

How to test the changes?

My overrides.ts file only gave Pokémon the psychic surge ability and priority moves to test. Separate tests forced opponent move sets to have priority moves as well. Didn't feel the need for automated tests, and there are no special requirements to test if this works.

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes manually?
• Are all unit tests still passing? (npm run test)
  • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
• Have I provided screenshots/videos of the changes (if applicable)?
  • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

• Has a locales PR been created on the locales repo?
  • If so, please leave a link to it here:
• Has the translation team been contacted for proofreading/translation?

[Snailman11]

Does your PR's behaviour in Double Battles match mainline? (Message/check plays from right to left)

DoublesMisty.mp4

[KennethWest]

Does your PR's behaviour in Double Battles match mainline? (Message/check plays from right to left)

DoublesMisty.mp4

I'm not sure this is applicable at the moment, since by current definition Psychic Terrain cannot block moves that target multiple or adjacent Pokémon even if they become priority moves.

[Madmadness65]

Just one change is necessary, since the BattleScene is called through globalScene now.

[KennethWest]

Just one change is necessary, since the BattleScene is called through globalScene now.

Thanks, I've committed the change.