-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit styling of table element #116
base: master
Are you sure you want to change the base?
Conversation
Welcome! Congrats on your first pull request to the Cayman theme. If you haven't already, please be sure to check out the contributing guidelines. |
hi @godalming123 I've published it. Here's a direct link to the branch |
great thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
It's not stale and it's a usefuful improvement! |
I've endeavoured to make as few changes to the behaviour/ structure of
table
as possible while giving it a more modern look.I've used the variable
$section-headings-color
, and a modified version for the even table rows#159957
->#f5f9f7
(comment mentioning this in the theme's scss file). Not sure what the most appropriate solution with these colours is. Does anyone have any suggestions?I've also toyed with this other combination:
#157a76
->#f5faf6
, the former is a colour from the middle-ish of.page-header
slinear-gradient
. This has a nice teal effect, and differentiates it from the heading colour, yet is still aligned with the theme. If these colours are preferred, I'll amend my commit to pop them invariables.scss
:)Before
After