Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit styling of table element #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olibooty
Copy link

I've endeavoured to make as few changes to the behaviour/ structure of table as possible while giving it a more modern look.

I've used the variable $section-headings-color, and a modified version for the even table rows #159957 -> #f5f9f7 (comment mentioning this in the theme's scss file). Not sure what the most appropriate solution with these colours is. Does anyone have any suggestions?

I've also toyed with this other combination: #157a76 -> #f5faf6, the former is a colour from the middle-ish of .page-headers linear-gradient. This has a nice teal effect, and differentiates it from the heading colour, yet is still aligned with the theme. If these colours are preferred, I'll amend my commit to pop them in variables.scss :)

Before

Screenshot 2021-01-27 at 13 48 50

After

Screenshot 2021-01-27 at 13 48 58

@welcome
Copy link

welcome bot commented Jan 27, 2021

Welcome! Congrats on your first pull request to the Cayman theme. If you haven't already, please be sure to check out the contributing guidelines.

@godalming123
Copy link

godalming123 commented Aug 19, 2021

loving this new design could you deploy on github pages release? Just do this:

  1. go to the settings tab on the repo.
  2. select pages from the sidebar on the left
  3. change the value in the dropdown from none to whatever branch you made the changes on
  4. click save and after about 2 minutes github will build your site when your site is built it will say your site is published at somewhere but it will actually take another 6 or so minutes to deploy than you can visit the link and see your changes. if you get an error when doploying it is likely because your scss is invalid and you can then fix it.
    image

@olibooty
Copy link
Author

hi @godalming123 I've published it. Here's a direct link to the branch

@godalming123
Copy link

great thanks

Copy link

@godalming123 godalming123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 8, 2022
@godalming123
Copy link

It's not stale and it's a usefuful improvement!

@stale stale bot removed the wontfix label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants