try some lints (flutter#12719)

* try some lints * remove avoid_returning_this rule
pahlevikun · Nov 10, 2017 · aefc62f · aefc62f
1 parent 454db9d
commit aefc62f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -85,10 +85,10 @@ linter:
     - avoid_null_checks_in_equality_operators
     # - avoid_positional_boolean_parameters # not yet tested
     - avoid_return_types_on_setters
-    # - avoid_returning_null # not yet tested
-    # - avoid_returning_this # not yet tested
+    # - avoid_returning_null # we do this commonly
+    # - avoid_returning_this # https://github.com/dart-lang/linter/issues/842
     # - avoid_setters_without_getters # not yet tested
-    # - avoid_types_on_closure_parameters # not yet tested
+    # - avoid_types_on_closure_parameters # conflicts with always_specify_types
     - await_only_futures
     - camel_case_types
     # - cascade_invocations # not yet tested

diff --git a/analysis_options_repo.yaml b/analysis_options_repo.yaml
@@ -79,10 +79,10 @@ linter:
     - avoid_null_checks_in_equality_operators
     # - avoid_positional_boolean_parameters # not yet tested
     - avoid_return_types_on_setters
-    # - avoid_returning_null # not yet tested
-    # - avoid_returning_this # not yet tested
+    # - avoid_returning_null # we do this commonly
+    # - avoid_returning_this # https://github.com/dart-lang/linter/issues/842
     # - avoid_setters_without_getters # not yet tested
-    # - avoid_types_on_closure_parameters # not yet tested
+    # - avoid_types_on_closure_parameters # conflicts with always_specify_types
     - await_only_futures
     - camel_case_types
     # - cascade_invocations # not yet tested