Skip to content

Commit

Permalink
cmd/dlv: make core command limitations more prominent (go-delve#2031)
Browse files Browse the repository at this point in the history
  • Loading branch information
aarzilli authored May 4, 2020
1 parent 5b7d764 commit 0f83fa6
Show file tree
Hide file tree
Showing 27 changed files with 6,925 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Documentation/usage/dlv_core.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ Examine a core dump.
### Synopsis


Examine a core dump.
Examine a core dump (only supports linux and windows core dumps).

The core command will open the specified core file and the associated
executable and let you examine the state of the process when the
core dump was taken.

Currently supports linux/amd64 core files and windows/amd64 minidumps.
Currently supports linux/amd64 and linux/arm64 core files and windows/amd64 minidumps.

```
dlv core <executable> <core>
Expand Down
4 changes: 2 additions & 2 deletions cmd/dlv/cmds/commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -264,13 +264,13 @@ to know what functions your process is executing.`,
coreCommand := &cobra.Command{
Use: "core <executable> <core>",
Short: "Examine a core dump.",
Long: `Examine a core dump.
Long: `Examine a core dump (only supports linux and windows core dumps).
The core command will open the specified core file and the associated
executable and let you examine the state of the process when the
core dump was taken.
Currently supports linux/amd64 core files and windows/amd64 minidumps.`,
Currently supports linux/amd64 and linux/arm64 core files and windows/amd64 minidumps.`,
PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
if len(args) != 2 {
return errors.New("you must provide a core file and an executable")
Expand Down
3 changes: 2 additions & 1 deletion cmd/dlv/dlv_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,8 @@ func TestGeneratedDoc(t *testing.T) {
defer protest.SafeRemoveAll(tempDir)
cmd := exec.Command("go", "run", "_scripts/gen-usage-docs.go", tempDir)
cmd.Dir = projectRoot()
cmd.Run()
err = cmd.Run()
assertNoError(err, t, "go run _scripts/gen-usage-docs.go")
entries, err := ioutil.ReadDir(tempDir)
assertNoError(err, t, "ReadDir")
for _, doc := range entries {
Expand Down
7 changes: 7 additions & 0 deletions cmd/dlv/tools.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package main

// List packages used by _scripts

import (
_ "github.com/spf13/cobra/doc"
)
21 changes: 21 additions & 0 deletions vendor/github.com/cpuguy83/go-md2man/LICENSE.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions vendor/github.com/cpuguy83/go-md2man/md2man/md2man.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

285 changes: 285 additions & 0 deletions vendor/github.com/cpuguy83/go-md2man/md2man/roff.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions vendor/github.com/russross/blackfriday/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 0f83fa6

Please sign in to comment.