re-use globalLocalDrives properly (minio#18721)

panda-sheep · Dec 29, 2023 · 5b2ced0 · 5b2ced0
1 parent 8a0ba09
commit 5b2ced0
Showing 1 changed file with 17 additions and 3 deletions.
diff --git a/cmd/erasure-sets.go b/cmd/erasure-sets.go
@@ -262,9 +262,11 @@ func (s *erasureSets) connectDisks() {
 			s.erasureDisks[setIndex][diskIndex] = disk
 			s.erasureDisksMu.Unlock()
 
-			globalLocalDrivesMu.Lock()
-			globalLocalSetDrives[s.poolIndex][setIndex][diskIndex] = disk
-			globalLocalDrivesMu.Unlock()
+			if disk.IsLocal() && globalIsDistErasure {
+				globalLocalDrivesMu.Lock()
+				globalLocalSetDrives[s.poolIndex][setIndex][diskIndex] = disk
+				globalLocalDrivesMu.Unlock()
+			}
 		}(endpoint)
 	}
 
@@ -403,6 +405,18 @@ func newErasureSets(ctx context.Context, endpoints PoolEndpoints, storageDisks [
 				if disk == nil {
 					continue
 				}
+
+				if disk.IsLocal() && globalIsDistErasure {
+					globalLocalDrivesMu.RLock()
+					ldisk := globalLocalSetDrives[poolIdx][i][j]
+					if ldisk == nil {
+						globalLocalDrivesMu.RUnlock()
+						continue
+					}
+					disk = ldisk
+					globalLocalDrivesMu.RUnlock()
+				}
+
 				innerWg.Add(1)
 				go func(disk StorageAPI, i, j int) {
 					defer innerWg.Done()