Skip to content

BLD: allow to build with non-MSVC compilers on Windows #61404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/build_pandas/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ runs:
run: |
if [[ ${{ inputs.editable }} == "true" ]]; then
pip install -e . --no-build-isolation -v --no-deps \
-Csetup-args="--werror"
-Csetup-args="--werror" -Csetup-args="--vsenv"
else
pip install . --no-build-isolation -v --no-deps \
-Csetup-args="--werror"
-Csetup-args="--werror" -Csetup-args="--vsenv"
fi
shell: bash -el {0}
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ jobs:
python -m pip install --upgrade pip setuptools wheel meson[ninja]==1.2.1 meson-python==0.13.1
python -m pip install --pre --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple numpy
python -m pip install versioneer[toml] python-dateutil tzdata cython hypothesis>=6.84.0 pytest>=7.3.2 pytest-xdist>=3.4.0 pytest-cov
python -m pip install -ve . --no-build-isolation --no-index --no-deps -Csetup-args="--werror"
python -m pip install -ve . --no-build-isolation --no-index --no-deps -Csetup-args="--werror" -Csetup-args="--vsenv"
python -m pip list

- name: Run Tests
Expand Down
4 changes: 1 addition & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,6 @@ versionfile_build = "pandas/_version.py"
tag_prefix = "v"
parentdir_prefix = "pandas-"

[tool.meson-python.args]
setup = ['--vsenv'] # For Windows

[tool.cibuildwheel]
skip = "cp36-* cp37-* cp38-* cp39-* pp* *_i686 *_ppc64le *_s390x"
build-verbosity = 3
Expand All @@ -162,6 +159,7 @@ before-build = "PACKAGE_DIR={package} bash {package}/scripts/cibw_before_build.s
[tool.cibuildwheel.windows]
environment = {}
before-build = "pip install delvewheel && bash {package}/scripts/cibw_before_build_windows.sh"
config-settings = "setup-args=--vsenv"
test-command = """
set PANDAS_CI='1' && \
python -c "import pandas as pd; \
Expand Down
Loading