-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Searchsorted branch #61435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Searchsorted branch #61435
Conversation
Thanks @GSAUC3 for the PR. Is there and issue, or has there been any discussion about this elsewhere? |
Hi @datapythonista, this was the issue #14833 , against which i made the pull request. |
HI, I had ran pytest and pre-commit locally, is it possible to run all these test locally? |
@GSAUC3 Add a return statement in your function after
|
hi, @datapythonista , I am having trouble running all these tests, locally, before committing my code, so far i have only ran the pytest, locally, and that worked, could you please, guide me, how to set up the testing environment locally, before each commit? will running |
pre-commit should run automatically if it's set up to work as intended. You have all the information on how to set up the development environment, run tests... in the development documentation: https://pandas.pydata.org/docs/development/index.html |
Hi, @datapythonista, this part of the error messages tells, us that searchsorted method should fail, but it is passing, am i correct?
|
Yes, that's correct. I guess we have an xfail for the test that should be removed. |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.