Skip to content

Searchsorted branch #61435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

GSAUC3
Copy link

@GSAUC3 GSAUC3 commented May 12, 2025

@datapythonista
Copy link
Member

Thanks @GSAUC3 for the PR. Is there and issue, or has there been any discussion about this elsewhere?

@GSAUC3
Copy link
Author

GSAUC3 commented May 12, 2025

Hi @datapythonista, this was the issue #14833 , against which i made the pull request.

@GSAUC3
Copy link
Author

GSAUC3 commented May 12, 2025

HI, I had ran pytest and pre-commit locally, is it possible to run all these test locally?

@RB-zentronlabs
Copy link

@GSAUC3 Add a return statement in your function after except block.

  • check teh docstring and proper typing hints, IndexOpsMixin check this class, where searchsorted has a properly defined parameter structure.

@GSAUC3
Copy link
Author

GSAUC3 commented May 15, 2025

hi, @datapythonista , I am having trouble running all these tests, locally, before committing my code, so far i have only ran the pytest, locally, and that worked, could you please, guide me, how to set up the testing environment locally, before each commit?

will running
pre-commit run --all-files
suffice?

@datapythonista
Copy link
Member

pre-commit should run automatically if it's set up to work as intended. You have all the information on how to set up the development environment, run tests... in the development documentation: https://pandas.pydata.org/docs/development/index.html

@RB-zentronlabs
Copy link

RB-zentronlabs commented May 15, 2025

Hi, @datapythonista, this part of the error messages tells, us that searchsorted method should fail, but it is passing, am i correct?

=================================== FAILURES ===================================
__________________________ test_searchsorted[tuples] ___________________________
[gw0] darwin -- Python 3.10.17 /Users/runner/micromamba/envs/test/bin/python3.10
[XPASS(strict)] np.searchsorted doesn't work on pd.MultiIndex: GH 1[48](https://github.com/pandas-dev/pandas/actions/runs/15033468287/job/42250710830?pr=61435#step:5:52)33
___________________ test_searchsorted[mi-with-dt64tz-level] ____________________
[gw0] darwin -- Python 3.10.17 /Users/runner/micromamba/envs/test/bin/python3.10
[XPASS(strict)] np.searchsorted doesn't work on pd.MultiIndex: GH 14833
___________________________ test_searchsorted[multi] ___________________________

@datapythonista
Copy link
Member

Hi, @datapythonista, this part of the error messages tells, us that searchsorted method should fail, but it is passing, am i correct?

Yes, that's correct. I guess we have an xfail for the test that should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiarray searchsorted fails
3 participants