REF: get rid of ArrowStringArrayNumpySemantics #62165
Merged
+219
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 21, 2025
|
|
||
| if dtype is None: | ||
| dtype = StringDtype(storage="pyarrow", na_value=libmissing.NA) | ||
| self._dtype = dtype |
There was a problem hiding this comment.
Worth raising if dtype.storage != "pyarrow"?
There was a problem hiding this comment.
Or should __init__ only accept na_value: libmissing.NAType | np.nan = libmissing.NA?
There was a problem hiding this comment.
I think accepting dtype is more idiomatic. I’d be ok with adding that check but don’t think it necessary
mroeschke
approved these changes
Aug 22, 2025
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.analogous to #62149